UI/UX: Minimal HTML with missing meta tags#1713
Conversation
The API Explorer index.html lacks viewport meta tag for proper mobile rendering, no favicon, no lang attribute, and no accessibility features. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the index.html file for the API Explorer by adding a language attribute, refining the viewport meta tag, and introducing an SVG favicon. Feedback was provided to include a character set declaration for improved rendering and security, and to fix the empty SVG favicon to ensure it displays a visible icon.
| <html lang="en"> | ||
| <head> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> |
There was a problem hiding this comment.
The document is missing a character set declaration. It is a best practice to include <meta charset="utf-8"> as the first element in the <head> to ensure correct character rendering and improve security.
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | |
| <meta charset="utf-8" /> | |
| <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| <meta name="viewport" content="width=device-width" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <title>API Explorer</title> | ||
| <link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.9em' font-size='90'></text></svg>" /> |
There was a problem hiding this comment.
The SVG favicon contains an empty <text> element, which results in no icon being displayed. Please add a character or symbol (e.g., an emoji or a letter) inside the <text> tag to make the icon visible.
| <link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.9em' font-size='90'></text></svg>" /> | |
| <link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='.9em' font-size='90'>🚀</text></svg>" /> |
1 participant
Summary
UI/UX: Minimal HTML with missing meta tags
Problem
Severity:
Medium| File:packages/api-explorer/public/index.html:L1The API Explorer index.html lacks viewport meta tag for proper mobile rendering, no favicon, no lang attribute, and no accessibility features.
Solution
Add , , and consider adding a favicon link.
Changes
packages/api-explorer/public/index.html(modified)